[PATCH] D119351: Update all LLVM documentation mentioning runtimes in LLVM_ENABLE_PROJECTS

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 9 16:33:44 PST 2022

MaskRay accepted this revision.
MaskRay added a comment.

Thanks  for improving the documentation. I occasionally see folks (and two today!) puzzled by LLVM_ENABLE_RUNTIMES and this patch should help them.

Personally I use the `-S -B` style (actually `-H`, but now I see that `-S` is documented I will switch).
I sometimes twiddle with a cmake file and spawn multiple builds.
Not changing the work directory makes my commands simpler, but I do see @Quuxplusone's point about `-DCMAKE_INSTALL_PREFIX=$(pwd)/install`.

I rarely use `CMAKE_INSTALL_PREFIX`. When I need it, I accept the slight inconvenience of duplicating the build directory twice for `-B` and `-DCMAKE_INSTALL_PREFIX`.

I have read the updated and they look good to me, but happy if we switch to @Quuxplusone's style.
I passes the link to some folks and hope that fresh eyes with less LLVM_ENABLE_RUNTIMES experience can make suggestions.

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list