[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

[Mitch Phillips via Phabricator via cfe-commits]

hctim planned changes to this revision.
hctim marked 8 inline comments as done.
hctim added a comment.

Pushed the [1/3] ELF note parsing over to D119381 <https://reviews.llvm.org/D119381>. Will leave this review for the clang-side changes, and send a new patch for the LLD changes. All of your comments are completed in my internal branch, and I'll upload that after the lld changes are landed.



================
Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:475
 def err_stack_tagging_requires_hardware_feature : Error<
-  "'-fsanitize=memtag' requires hardware support (+memtag)">;
+  "'-fsanitize=memtag-stack' requires hardware support (+memtag). For Armv8, "
+  "try compiling with -march=armv8a+memtag.">;
----------------
eugenis wrote:
> Split out renaming of memtag to memtag-stack first? This will remove a lot of diff from this patch.
splitting into elf -> lld -> clang as per Ray's suggestion, should reduce the diff enough.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118948/new/

https://reviews.llvm.org/D118948