[PATCH] D119199: replace clang LLVM_ENABLE_PLUGINS -> CLANG_PLUGIN_SUPPORT in tests

Wed Feb 9 14:06:35 PST 2022

cristian.adam resigned from this revision.
cristian.adam added a comment.
This revision is now accepted and ready to land.

In D119199#3309117 <https://reviews.llvm.org/D119199#3309117>, @vtjnash wrote:

> @cristian.adam Is this good now? You are blocking merging this, but I think it is ready to land, and I would like to not hold it up for other people if it is fixing their issues (and the issues you discovered too)

I did a rebase on `release/14.x`, applied this commit and, got the same error:

  -- SampleAnalyzerPlugin ignored -- Loadable modules not supported on this platform.
  CMake Error at C:/Projects/llvm-project/repo/clang/cmake/modules/AddClang.cmake:185 (target_link_libraries):
    Utility target "SampleAnalyzerPlugin" must not be used as the target of a
    target_link_libraries call.
  Call Stack (most recent call first):
    C:/Projects/llvm-project/repo/clang/lib/Analysis/plugins/SampleAnalyzer/CMakeLists.txt:8 (clang_target_link_libraries)

  -- CheckerDependencyHandlingAnalyzerPlugin ignored -- Loadable modules not supported on this platform.
  CMake Error at C:/Projects/llvm-project/repo/clang/cmake/modules/AddClang.cmake:185 (target_link_libraries):
    Utility target "CheckerDependencyHandlingAnalyzerPlugin" must not be used
    as the target of a target_link_libraries call.
  Call Stack (most recent call first):
    C:/Projects/llvm-project/repo/clang/lib/Analysis/plugins/CheckerDependencyHandling/CMakeLists.txt:8 (clang_target_link_libraries)

  -- CheckerOptionHandlingAnalyzerPlugin ignored -- Loadable modules not supported on this platform.
  CMake Error at C:/Projects/llvm-project/repo/clang/cmake/modules/AddClang.cmake:185 (target_link_libraries):
    Utility target "CheckerOptionHandlingAnalyzerPlugin" must not be used as
    the target of a target_link_libraries call.
  Call Stack (most recent call first):
    C:/Projects/llvm-project/repo/clang/lib/Analysis/plugins/CheckerOptionHandling/CMakeLists.txt:8 (clang_target_link_libraries)

I'll be away for a week, so I won't be blocking anybody now. I'll have to deal with building LLVM/Clang 14 when I come back.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119199/new/

https://reviews.llvm.org/D119199