[PATCH] D119370: [clang-tidy] add option performance-move-const-arg.CheckMoveToConstRef

[Yitzhak Mandelbaum via Phabricator via cfe-commits]

ymandel accepted this revision.
ymandel added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clang-tidy/performance/MoveConstArgCheck.cpp:197-198
     }
   } else if (ReceivingExpr) {
-    if ((*InvocationParmType)->isRValueReferenceType())
+    if ((*InvocationParmType)->isRValueReferenceType() || !CheckMoveToConstRef)
       return;
----------------
nit, up to you. I think this way is a little clearer b/c it reads "proceed on this branch if the check is configured to "check move to const ref"".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119370/new/

https://reviews.llvm.org/D119370