[PATCH] D119366: [clangd] Use `ObjCProtocolLoc` for generalized ObjC protocol support

David Goldman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 9 12:30:07 PST 2022


dgoldman created this revision.
Herald added subscribers: usaxena95, kadircet, arphaman.
dgoldman requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.

This removes clangd's existing workaround in favor of proper support
via the newly added `ObjCProtocolLoc`. This improves support by
allowing clangd to properly identify which protocol is selected
now that `ObjCProtocolLoc` gets its own ASTNode.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D119366

Files:
  clang-tools-extra/clangd/FindTarget.cpp
  clang-tools-extra/clangd/Selection.cpp
  clang-tools-extra/clangd/unittests/FindTargetTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D119366.407247.patch
Type: text/x-patch
Size: 6283 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220209/e9763765/attachment-0001.bin>


More information about the cfe-commits mailing list