[PATCH] D119296: KCFI sanitizer

[Sami Tolvanen via Phabricator via cfe-commits]

samitolvanen marked an inline comment as not done.
samitolvanen added inline comments.


================
Comment at: clang/include/clang/Basic/Attr.td:696
+def KCFIUnchecked : Attr {
+  let Spellings = [Clang<"kcfi_unchecked">];
+  let Subjects = SubjectList<[Var, TypedefName]>;
----------------
joaomoreira wrote:
> Are you considering that perhaps one could use KCFI and X86 CET/IBT at the same time? If not, is there a reason for not just reusing the existing "nocf_check" attribute?
I don't see why they couldn't be used at the same time, but the reason I'm not reusing `nocf_check` is that it's specific to x86 / CET and I didn't want to change its semantics, especially since KCFI targets other architectures too. Happy to hear thoughts about this, of course.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119296/new/

https://reviews.llvm.org/D119296