[PATCH] D118520: [clang-tidy] Output currently processing check and nodes on crash
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Feb 9 06:37:39 PST 2022
aaron.ballman accepted this revision.
aaron.ballman added a comment.
Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:349-352
+ // This should be an assert, but asserts shouldn't be used in signal
+ // handlers
+ if (!CurContext)
This function does a whole lot of things that shouldn't be used in signal handlers: http://eel.is/c++draft/support.signal#3
Unless you know of a problem from the assert, I'd say go ahead and use it.
Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:165
: DiagEngine(nullptr), OptionsProvider(std::move(OptionsProvider)),
+ CurrentlyProcessing(nullptr), Profile(false),
> Does the LLVM style guide say anything about preferring member initializers over initializing constant expressions?
I know we document that we prefer sticking with the local style used around the change. I don't know if we say anything about initializers, but for new code I've been suggesting folks use member initializers when possible.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits