[PATCH] D118847: Added early exit for defaulted FunctionDecls.

Kirill Bobyrev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 9 05:45:06 PST 2022

kbobyrev added a comment.

In D118847#3307497 <https://reviews.llvm.org/D118847#3307497>, @Febbe wrote:

> Can I still add a diff, or does this cause a revoke (apply the rest of the feedback)? 
> Also, is the commit added automatically to the repo, or do I / another one have to rebase it.
> Sorry for those questions, this is my first contribution to llvm.

Yes, you can add changes after LGTM, it might add the warning "landed changes with unreviewed diff" but it's generally OK if the changes are the suggestions.

Someone needs to commit the patch to the monorepo. Do you have the commit access? If not, I can do that for you once you indicate you are done with the changes.



More information about the cfe-commits mailing list