[PATCH] D118052: [X86] Fix CodeGen Module Flag for -mibt-seal

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added subscribers: cfe-commits, aaron.ballman.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a comment.

In D118052#3273241 <https://reviews.llvm.org/D118052#3273241>, @gftg wrote:

> Thanks, João, that's exactly what I needed. For the record, the use of `-DLLVM_ENABLE_ASSERTIONS=ON` makes it reproducible. I don't understand why, yet, but there you go.

This would be good to track down -- if it is related to enabling assertions, that suggests we have an assert somewhere with an expression in it where we need the side effects, and when assertions are enabled, we're losing those side effects. That makes me worried we may be silencing the real bug with this workaround.

FWIW, I can reproduce the issue in the test case with and without assertions enabled without the changes in CompilerInvocations.cpp, and applying the rest of the patch does fix the issue for me.

The questions from @pengfei are good ones we should address.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118052/new/

https://reviews.llvm.org/D118052