[PATCH] D118847: Added early exit for defaulted FunctionDecls.

Kirill Bobyrev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 9 04:21:23 PST 2022


kbobyrev accepted this revision.
kbobyrev added a comment.
This revision is now accepted and ready to land.

LG, thanks!



================
Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-use-trailing-return-type-cxx20.cpp:71
+  template <typename T>
+  requires(T{0}) //
+      friend constexpr auto
----------------
Febbe wrote:
> kbobyrev wrote:
> > nit: `//` looks unrelated
> I used the `//` to break the line there (avoids // clang-format off/on)
> 
> in my opinion, it should look like this:
> 
> `template <typename T> requires(T{0}) \n`
I think it's better spelled out explicitly (otherwise the intent is unclear) or just have the clang-format apply the formatting (since it doesn't seem very important here as it's a test).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118847/new/

https://reviews.llvm.org/D118847



More information about the cfe-commits mailing list