[PATCH] D118847: Added early exit for defaulted FunctionDecls.

Kirill Bobyrev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 9 04:01:25 PST 2022


kbobyrev added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:407
 
-  if (F->getLocation().isInvalid())
+  // operator<=> generates also the AST of e.g. operator==, which is implicit
+  if (F->getLocation().isInvalid() || F->isImplicit())
----------------
kbobyrev wrote:
> nit: probably explains the situation better
nit: Capitalization (start with T), dot at the end.


================
Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-use-trailing-return-type-cxx20.cpp:71
+  template <typename T>
+  requires(T{0}) //
+      friend constexpr auto
----------------
nit: `//` looks unrelated


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118847/new/

https://reviews.llvm.org/D118847



More information about the cfe-commits mailing list