[PATCH] D118990: [pseudo] Add first and follow set computation in Grammar.

[Sam McCall via Phabricator via cfe-commits]

sammccall added inline comments.


================
Comment at: clang/unittests/Tooling/Syntax/Pseudo/GrammarTest.cpp:25
 
 MATCHER_P(TargetID, SID, "") { return arg.Target == SID; }
 template <typename... T> testing::Matcher<const Rule &> Sequence(T... IDs) {
----------------
hokein wrote:
> sammccall wrote:
> > whoops, I missed these in the previous review, these should really be `targetID` and `sequence` as they're functions.
> they're public member variables :)
`MATCHER_P(TargetID)` produces a template function named `TargetID`. It should be named `targetID` per the style rules.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118990/new/

https://reviews.llvm.org/D118990