[PATCH] D119309: [Driver][test] Clean up some AIX tests

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 8 20:29:26 PST 2022


MaskRay created this revision.
MaskRay added reviewers: DiggerLin, hubert.reinterpretcast, jasonliu, stevewan, Xiangling_L.
Herald added a reviewer: ctetreau.
MaskRay requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

- For `-###`, `-o %t.o` is unnecessary if we don't specifically test the output filename.
- --target= is the canonical spelling. -target is a legacy spelling which unfortunately cannot be removed because there are too many uses.
- -no-canonical-prefixes uses the dereferenced absolute path for the cc1 command. For most tests "-cc1" is sufficient to identify the command line, no need to specifically test the "clang" command, and -no-canonical-prefixes can removed.
- --unwindlib= is the preferred spelling. -u is a short option taking a value, which means a -uwindlib= typo cannot be detected.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D119309

Files:
  clang/test/Driver/aix-as.c
  clang/test/Driver/aix-ld.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D119309.407037.patch
Type: text/x-patch
Size: 30025 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220209/937d8d0c/attachment-0001.bin>


More information about the cfe-commits mailing list