[PATCH] D116861: [UBSan] Fix incorrect alignment reported when global new returns an offset pointer

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 8 16:15:21 PST 2022


rnk added inline comments.


================
Comment at: clang/lib/CodeGen/CGExprCXX.cpp:1658-1659
           Target.getNewAlign(), getContext().getTypeSize(allocType)));
       allocationAlign = std::max(
           allocationAlign, getContext().toCharUnitsFromBits(AllocatorAlign));
     }
----------------
I believe John's proposal is to remove this `max` here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116861/new/

https://reviews.llvm.org/D116861



More information about the cfe-commits mailing list