[PATCH] D119216: [AMDGPU] replace hostcall module flag with function attribute
Matt Arsenault via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Feb 8 08:58:20 PST 2022
arsenm added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:198
+ const auto *STI = TM.getMCSubtargetInfo();
+ return llvm::AMDGPU::getHostcallImplicitArgPosition(STI);
+ }
----------------
arsenm wrote:
> The ABI should not be a property of the subtarget, and the global subtarget shouldn't be used
This is still depending on the global subtarget. There's no reason isHsaAbiVersion* should depend on the subtarget. All it's doing is checking global properties
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119216/new/
https://reviews.llvm.org/D119216
More information about the cfe-commits
mailing list