[PATCH] D119216: [AMDGPU] replace hostcall module flag with function attribute
Sameer Sahasrabuddhe via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Feb 8 05:35:35 PST 2022
sameerds added inline comments.
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:589
+ A.checkForAllCallLikeInstructions(CheckForHostcallAccess, *this,
> Always check the return value, if it is false something went wrong and some calls might have been missed. Basically,
> if (!A.check...)
> NeedsHostCallPtr = true;
> then you also can just return false in the callback w/o setting it.
Thanks! This eliminated the variable. Also used the opportunity to get more creative with the callback names!
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits