[clang-tools-extra] 0851970 - Make run-clang-tidy.py print the configured checks correctly

[Aaron Ballman via cfe-commits]

Author: Jesko Appelfeller
Date: 2022-02-08T08:32:04-05:00
New Revision: 0851970af5771f6721c29d066c88a72db823ba83

URL: https://github.com/llvm/llvm-project/commit/0851970af5771f6721c29d066c88a72db823ba83
DIFF: https://github.com/llvm/llvm-project/commit/0851970af5771f6721c29d066c88a72db823ba83.diff

LOG: Make run-clang-tidy.py print the configured checks correctly

The test invocation at the start of run-clang-tidy.py (line 257) prints
all enabled checks - meaning either the default set or anything
configured via the -checks option. If any checks were (un-)configured
via the -config option, these are not printed. This is confusing to the
user, since the list of checks that are printed may be different from
the list of checks that are used by the non-testing calls to clang-tidy,
where the -config option is passed correctly.

This patch adds the -config option to the test invocation of clang-tidy
at the start of the script. This means that checks (un-)configured via
the -config option (rather than the -checks option) are applied
correctly, when printing the list of enabled checks.

Added: 
    

Modified: 
    clang-tools-extra/clang-tidy/tool/run-clang-tidy.py

Removed: 
    


################################################################################
diff  --git a/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py b/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py
index e6cff6a7414d1..090646c1b061b 100755
--- a/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py
+++ b/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py
@@ -254,12 +254,12 @@ def main():
     build_path = find_compilation_database(db_path)
 
   try:
-    invocation = [args.clang_tidy_binary, '-list-checks']
-    if args.allow_enabling_alpha_checkers:
-      invocation.append('-allow-enabling-analyzer-alpha-checkers')
-    invocation.append('-p=' + build_path)
-    if args.checks:
-      invocation.append('-checks=' + args.checks)
+    invocation = get_tidy_invocation("", args.clang_tidy_binary, args.checks,
+                                     None, build_path, args.header_filter,
+                                     args.allow_enabling_alpha_checkers,
+                                     args.extra_arg, args.extra_arg_before,
+                                     args.quiet, args.config, args.line_filter)
+    invocation.append('-list-checks')
     invocation.append('-')
     if args.quiet:
       # Even with -quiet we still want to check if we can call clang-tidy.