[PATCH] D119130: [clangd] NFC: Move stdlibg headers handling to Clang

[Kirill Bobyrev via Phabricator via cfe-commits]

kbobyrev added inline comments.


================
Comment at: clang/include/clang/Tooling/Inclusions/StandardLibrary.h:37
+  static llvm::Optional<Symbol> named(llvm::StringRef Scope,
+                                      llvm::StringRef Name);
+
----------------
kadircet wrote:
> should scope have trailing `::` ?
This is consistent with the current behavior; we can probably change it later.


================
Comment at: clang/include/clang/Tooling/Inclusions/StandardLibrary.h:66
+  Recognizer();
+  llvm::Optional<Symbol> operator()(const Decl *D);
+
----------------
kadircet wrote:
> what about macros?
For now, I'm just moving the code without adding any new capabilities. The only change is in `namespaceSymbols` (to break the dependency on clangd helpers) that Sam pointed out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119130/new/

https://reviews.llvm.org/D119130