[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

Diana Picus via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 8 00:22:45 PST 2022


rovka accepted this revision.
rovka added a comment.
This revision is now accepted and ready to land.

LGTM, thanks! I just have a minor nit, feel free to ignore it.



================
Comment at: flang/lib/Frontend/FrontendActions.cpp:471
+
+  if (!ci.IsOutputStreamNull()) {
+    llvmModule->print(
----------------
Nit: Can this be folded into the above if? (I.e. just write to os if you managed to create it, and add an else branch for the other case)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119012/new/

https://reviews.llvm.org/D119012



More information about the cfe-commits mailing list