[PATCH] D119201: [clang][Fuchsia] Ensure static sanitizer libs are only linked in after the -nostdlib check
Roland McGrath via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Feb 7 16:10:34 PST 2022
mcgrathr added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:130
- bool NeedsSanitizerDeps = addSanitizerRuntimes(ToolChain, Args, CmdArgs);
bool NeedsXRayDeps = addXRayRuntime(ToolChain, Args, CmdArgs);
AddLinkerInputs(ToolChain, Inputs, Args, CmdArgs, JA);
----------------
I think all these runtime additions need to be conditional. There must be no kinds of implicit link inputs at all when using -nostdlib.
I'm not sure what matters or doesn't wrt their relative order vs AddLinkerInputs.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119201/new/
https://reviews.llvm.org/D119201
More information about the cfe-commits
mailing list