[PATCH] D111100: enable plugins for clang-tidy

[Jameson Nash via Phabricator via cfe-commits]

vtjnash added a comment.

It is a somewhat worthless test IMO, and might belong better in LLVM itself (where this functionality is defined), but there does not appear to be any other like it currently, and it was requested by a previous reviewer. Comparing to the code in LLVMTestingSupport, does this fix it for you:

  diff --git a/clang-tools-extra/test/CMakeLists.txt b/clang-tools-extra/test/CMakeLists.txt
  index 9321457ae1a3..17cc12473565 100644
  --- a/clang-tools-extra/test/CMakeLists.txt
  +++ b/clang-tools-extra/test/CMakeLists.txt
  @@ -87,6 +87,15 @@ if (NOT LLVM_INSTALL_TOOLCHAIN_ONLY)
         PLUGIN_TOOL clang-tidy
         DEPENDS clang-tidy-headers)
   
  +  if(CLANG_BUILT_STANDALONE)
  +    # LLVMHello library is needed below
  +    if (EXISTS ${LLVM_MAIN_SRC_DIR}/lib/Transforms/Hello
  +       AND NOT TARGET LLVMHello)
  +      add_subdirectory(${LLVM_MAIN_SRC_DIR}/lib/Transforms/Hello
  +        lib/Transforms/Hello)
  +    endif()
  +  endif()
  +
     if(TARGET CTTestTidyModule)
         list(APPEND CLANG_TOOLS_TEST_DEPS CTTestTidyModule LLVMHello)
         target_include_directories(CTTestTidyModule PUBLIC BEFORE "${CLANG_TOOLS_SOURCE_DIR}")


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111100/new/

https://reviews.llvm.org/D111100