[PATCH] D119051: Fix pod-packed functionality to use the C++11 definition of pod-ness

Mon Feb 7 11:48:59 PST 2022

rnk added a comment.

Looks like the test fails on the Windows pre-merge bot: https://buildkite.com/llvm-project/premerge-checks/builds/77696#1836f181-a998-4695-b587-a832392222ea

The debian bot seems to be failing for unrelated (clang tooling) reasons.

================
Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1892
+  bool FieldPacked =
+      (Packed && (!FieldClass || D->getType().isCXX11PODType(Context) ||
+                  Context.getLangOpts().getClangABICompat() <=
----------------
Bhramar.vatsa wrote:
> Maybe irrespective of the field's type itself, only important thing is just if it is a POD type or not?
Seems reasonable.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119051/new/

https://reviews.llvm.org/D119051