[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 7 09:25:07 PST 2022


aaron.ballman accepted this revision.
aaron.ballman added a comment.

The header bits LGTM aside from a nit I found with potential identifier conflicts. I don't feel super qualified to review the behavioral aspects of the change, but if others are happy with that, I'm happy with the header changes.



================
Comment at: clang/lib/Headers/mm_malloc.h:31-32
 static __inline__ void *__attribute__((__always_inline__, __nodebug__,
-                                       __malloc__))
-_mm_malloc(size_t __size, size_t __align)
-{
+                                       __malloc__, alloc_size(1),
+                                       alloc_align(2)))
+_mm_malloc(size_t __size, size_t __align) {
----------------
Protect against user macros.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117091/new/

https://reviews.llvm.org/D117091



More information about the cfe-commits mailing list