[PATCH] D118985: [flang][driver] Add support for `-emit-mlir`
Andrzej Warzynski via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Feb 7 02:55:46 PST 2022
awarzynski added inline comments.
================
Comment at: flang/include/flang/Frontend/FrontendActions.h:150
+//===----------------------------------------------------------------------===//
+class CodeGenAction : public FrontendAction {
+
----------------
schweitz wrote:
> This appears in a header file. Should there be doxygen comments?
Good point, I'll add something here.
================
Comment at: flang/include/flang/Frontend/FrontendActions.h:160
+ std::unique_ptr<mlir::ModuleOp> mlirModule_;
+ std::unique_ptr<mlir::MLIRContext> mlirCtx_;
+ /// }
----------------
schweitz wrote:
> The LLVM coding conventions do not require trailing undescores.
Good point, I'll change this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118985/new/
https://reviews.llvm.org/D118985
More information about the cfe-commits
mailing list