[PATCH] D119067: [clang-format] Fix DefinitionBlockSeparator extra empty lines

Marek Kurdej via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Feb 6 23:49:12 PST 2022


curdeius accepted this revision.
curdeius added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: clang/unittests/Format/DefinitionBlockSeparatorTest.cpp:305
                       "  int r = j / k;\n"
+                      "  if (struct S = getS()) {\n"
+                      "    // if condition\n"
----------------
curdeius wrote:
> I'd rather see this added in another function e.g. bar3, because otherwise you don't test what was tested before.
When I wrote this comment I thought that bar3 didn't exist... But well, I think I'll create a patch to clean up these tests a bit anyway.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119067/new/

https://reviews.llvm.org/D119067



More information about the cfe-commits mailing list