[PATCH] D119004: [NFC][analyzer] Allow CallDescriptions to be matched with CallExprs

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Feb 6 22:06:41 PST 2022


NoQ added a comment.

The original `lookup()` isn't exactly precise either, it's just slightly more precise as it has better access to path-sensitive information such as current values of function pointers, but this doesn't necessarily help given that these pointers can still be unknown. And when the information is not available the lookup silently fails in both cases.

But I can certainly get behind demotivating callers from calling the new function unless they know what they're doing. Maybe `lookupAsWritten()` to indicate that the function intentionally ignores the runtime state of the program and looks at the syntax only?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119004/new/

https://reviews.llvm.org/D119004



More information about the cfe-commits mailing list