[PATCH] D119067: [clang-format] Fix DefinitionBlockSeparator extra empty lines

[Marek Kurdej via Phabricator via cfe-commits]

curdeius requested changes to this revision.
curdeius added a comment.
This revision now requires changes to proceed.

Looks ok but please rework the tests to keep previous cases untouched.



================
Comment at: clang/unittests/Format/DefinitionBlockSeparatorTest.cpp:305
                       "  int r = j / k;\n"
+                      "  if (struct S = getS()) {\n"
+                      "    // if condition\n"
----------------
I'd rather see this added in another function e.g. bar3, because otherwise you don't test what was tested before.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119067/new/

https://reviews.llvm.org/D119067