[PATCH] D119018: [OpenMP] Add -Bsymbolic to arguments for GNU linker

Jon Chesterfield via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 4 10:09:35 PST 2022


JonChesterfield added a comment.

Can we drop an xfail in an existing test as part of this patch?



================
Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:581
+
+  // If we are linking for the device all symbols should be bound locally.
+  if (JA.isDeviceOffloading(Action::OFK_OpenMP))
----------------
Perhaps a comment to the effect that the symbols are protected which makes Bsymbolic redundant, except in that it works around an issue in bfd?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119018/new/

https://reviews.llvm.org/D119018



More information about the cfe-commits mailing list