[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

[Richard via Phabricator via cfe-commits]

LegalizeAdulthood added a comment.

In D118104#3295876 <https://reviews.llvm.org/D118104#3295876>, @JesApp wrote:

> In D118104#3294883 <https://reviews.llvm.org/D118104#3294883>, @LegalizeAdulthood wrote:
>
>> What is the feasibility of Python unit tests Instead of a heavy-weight `lit` oriented test?
>
> I don't know the code-base well enough to answer that. Is python used for testing purposes anywhere else?

I'm not sure; this is a little bit unusual because there is not much production
python code in llvm/clang.  I'm actually bumping into some grief in `check_clang_tidy.py`
that might go easier if I were to unit test some of the python itself.

> Anyway, I'm new here, so I don't want to tell you guys how to run things,
> but: In the projects I usually work on, a fix would get merged quickly and things
> like "let's write a test suite for this script" would go in the backlog. What's your
> opinion on that?

In this case, I think it's fine.  Generally speaking though, the coding guidelines for llvm/clang
require that tests be added alongside the new features or bug fixes.  This is certainly the case
when we add new checks, for instance.

See https://llvm.org/docs/DeveloperPolicy.html#test-cases


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118104/new/

https://reviews.llvm.org/D118104