[PATCH] D118999: [OpenCL] Adjust diagnostic for subgroup support.

[Anastasia Stulova via Phabricator via cfe-commits]

Anastasia added a comment.

In D118999#3296899 <https://reviews.llvm.org/D118999#3296899>, @azabaznov wrote:

> It seems hard to find a direct mention in the spec, but in the API spec:
>
> //CL_DEVICE_SUB_GROUP_INDEPENDENT_FORWARD_PROGRESS: Is CL_TRUE if this device supports independent forward progress of sub-groups, CL_FALSE otherwise. This query must return CL_TRUE for devices that support the cl_khr_subgroups extension, and must return CL_FALSE for devices that do not support subgroups.//

Ok, I would agree that the wording doesn't seem identical since the extension explicitly details forward progress behavior but the feature doesn't:
https://www.khronos.org/registry/OpenCL/specs/3.0-unified/html/OpenCL_Ext.html#cl_khr_subgroups

But I think it would make sense to add wording of it in the feature spec too otherwise it appears unspecified?

Anyway, at present, since they are not identical having separate handling of these teo seems reasonable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118999/new/

https://reviews.llvm.org/D118999