[PATCH] D118999: [OpenCL] Adjust diagnostic for subgroup support.

Fri Feb 4 07:42:03 PST 2022

Anastasia added a comment.

Btw can you point us to the spec reference please, I can't seem to find anything related to this: https://www.khronos.org/registry/OpenCL/specs/3.0-unified/html/OpenCL_C.html#subgroup-functions.

It would be nice to add the reference in the code comment too.

================
Comment at: clang/lib/Sema/SemaChecking.cpp:1048
+                                        S.getLangOpts())) {
+    S.Diag(Call->getBeginLoc(), diag::err_opencl_requires_subgroups)
+        << 1 << Call->getDirectCallee();
----------------
Ideally we should reduce the number of separate diagnostics, so could we just print something like:
`"cl_khr_subgroups extension or __opencl_c_subgroups OpenCL C 3.0 feature"`
when using `diag::err_opencl_requires_extension`?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118999/new/

https://reviews.llvm.org/D118999