[PATCH] D118976: clangd: Set a diagnostic on a code action resulting from a tweak

Christian Kandeler via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 4 02:33:09 PST 2022


ckandeler added a comment.

> This is assuming a semantic connection that we don't know exists.
> Without any more specific reason to draw this connection, this seems like a heuristic that could equally be applied by the client.

The difference being that the client would have to poke around in the technically opaque Command structure to find the range.
Seems possible, but presumably there are no guarantees about the properties?

> Is there a particular action/diagnostic pair you want this for?

Yes, -Wswitch/PopulateSwitch (which is the only quickfix kind of tweak at the moment).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118976/new/

https://reviews.llvm.org/D118976



More information about the cfe-commits mailing list