[PATCH] D118782: clangd: Add a break for every case in the PopulateSwitch tweak
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Feb 4 02:28:59 PST 2022
sammccall added a comment.
FWIW I prefer the existing behaviour (reasons below). @kadircet, thoughts?
- The output with `break` is harder to visually scan. (In styles where `break` goes on its own line)
- The output is annoying to edit when you *do* want to deal with blocks of cases at once. When editing cases individually anyway, I don't find typing `break` a burden.
- The goal isn't to provide a correct body, but to avoid having to remember/type all the cases. Any extra output is a distraction.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118782/new/
https://reviews.llvm.org/D118782
More information about the cfe-commits
mailing list