[PATCH] D114790: [syntax][pseudo] Add grammar facilities for the pseudo-parser

[Haojian Wu via Phabricator via cfe-commits]

hokein added inline comments.


================
Comment at: clang/lib/Tooling/Syntax/Pseudo/CMakeLists.txt:3
+
+add_clang_library(clangSyntaxPseudo
+  Grammar.cpp
----------------
thakis wrote:
> (i think the usual name would be "clangToolingSyntaxPseudo")
 (the name is too verbose, and we have a rough plan to lift Syntax directory up to Tooling, no timeline yet. For now, it might be better to follow the existing name pattern, fixed in b94f09524efe2789598eb8c1bf5f44f5b17148d6.


================
Comment at: clang/unittests/Tooling/Syntax/Pseudo/CMakeLists.txt:6
+add_clang_unittest(ClangPseudoTests
+  GrammarTests.cpp
+)
----------------
thakis wrote:
> ```
> thakis at thakis:~/src/llvm-project$ ls clang/unittests/**/*Test.cpp | wc -l
> 127
> thakis at thakis:~/src/llvm-project$ ls clang/unittests/**/*Tests.cpp | wc -l
> 1
> ```
fixed in  2189960e65a9c4a7056d1f07f8de5c3fda1888c3 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114790/new/

https://reviews.llvm.org/D114790