[PATCH] D118904: [clang][CodeGen] Use memory type representation in `va_arg`
Akira Hatanaka via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Feb 3 14:26:07 PST 2022
ahatanak accepted this revision.
ahatanak added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: clang/test/CodeGen/arm64-arguments.c:203
+ __builtin_va_start(ap, i);
+ // TODO: Add proper checks here.
+ _Bool b = __builtin_va_arg(ap, _Bool);
----------------
jansvoboda11 wrote:
> Not sure what to check here. Currently, we're just verifying the compiler doesn't crash.
If `CreateStore` is crashing, you can check the store instruction is being emitted with the correct type.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118904/new/
https://reviews.llvm.org/D118904
More information about the cfe-commits
mailing list