[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

Thu Feb 3 14:00:48 PST 2022

dyung added a comment.

In D114732#3294794 <https://reviews.llvm.org/D114732#3294794>, @devin.jeanpierre wrote:

> Oops, sorry about that. What is the correct way to test/reproduce the change? Do I / can I submit builds to the buildbot manually for testing?
>
> Also, should I be rolling back this change, or no? Not sure of the protocol here, this is my first change to Clang.
>
> P.S. that breakage is disturbing -- I would not have expected this sort of failure on any platform, and I'm not sure if it reflects a bug on PS4. (It seems to be that structs are passed in registers, even if the member variables of that struct cannot be.)

Reproducing it should be as simple as just rerunning the test with the PS4 triple, x86_64-scei-ps4 and comparing that output with what is expected. If it helps, I noticed that it seems to reproduce on both linux/windows.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114732/new/

https://reviews.llvm.org/D114732