[PATCH] D118428: [clang-cl] Support the /JMC flag

[Reid Kleckner via Phabricator via cfe-commits]

rnk added a comment.

In D118428#3294411 <https://reviews.llvm.org/D118428#3294411>, @ychen wrote:

> The passes in `lib/Transforms/Instrumentation` runs with `EmitAssemblyHelper::RunOptimizationPipeline`. JMC pass runs with `EmitAssemblyHelper::RunCodegenPipeline`.

Sure, but that's a choice. Most of the instrumentation passes (ASan) are also designed to run late to avoid interfering with middle end optimization. Is there a specific reason that JMC has to be a codegen pass? Maybe you've already mentioned it, apologies if so.

As for whether this should be addressed in a follow-up, I think it's best to make sure we have the right library structure first, and then iterate on the implementation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118428/new/

https://reviews.llvm.org/D118428