[PATCH] D118911: [clang-format] regression from clang-format v13
MyDeveloperDay via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Feb 3 10:34:05 PST 2022
MyDeveloperDay updated this revision to Diff 405705.
MyDeveloperDay added a comment.
Simply logic - review comment
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118911/new/
https://reviews.llvm.org/D118911
Files:
clang/lib/Format/UnwrappedLineParser.cpp
clang/unittests/Format/FormatTest.cpp
Index: clang/unittests/Format/FormatTest.cpp
===================================================================
--- clang/unittests/Format/FormatTest.cpp
+++ clang/unittests/Format/FormatTest.cpp
@@ -23665,6 +23665,7 @@
verifyFormat("struct Y<[] { return 0; }> {};", Style);
verifyFormat("struct Z : X<decltype([] { return 0; }){}> {};", Style);
+ verifyFormat("template <int N> struct Foo<char[N]> {};", Style);
}
TEST_F(FormatTest, RemoveBraces) {
Index: clang/lib/Format/UnwrappedLineParser.cpp
===================================================================
--- clang/lib/Format/UnwrappedLineParser.cpp
+++ clang/lib/Format/UnwrappedLineParser.cpp
@@ -3057,7 +3057,8 @@
}
if (FormatTok->is(tok::l_square)) {
FormatToken *Previous = FormatTok->Previous;
- if (!Previous || Previous->isNot(tok::r_paren)) {
+ if (!Previous ||
+ !(Previous->is(tok::r_paren) && Previous->isTypeOrIdentifier())) {
// Don't try parsing a lambda if we had a closing parenthesis before,
// it was probably a pointer to an array: int (*)[].
if (!tryToParseLambda())
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D118911.405705.patch
Type: text/x-patch
Size: 1144 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220203/b2aef374/attachment.bin>
More information about the cfe-commits
mailing list