[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

Shilei Tian via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 3 10:28:21 PST 2022


tianshilei1992 added inline comments.


================
Comment at: clang/test/OpenMP/atomic_ast_print.cpp:35
   }
+// omp50-error at +4 {{unexpected OpenMP clause 'compare' in directive '#pragma omp atomic'}}
+// omp50-note at +4 {{expected an expression statement}}
----------------
ABataev wrote:
> ast print tests are usually successful, better to add/modify special tests for incorrect cases (the ones ending with _messages.cpp)
Yeah, I'll also do that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116637/new/

https://reviews.llvm.org/D116637



More information about the cfe-commits mailing list