[PATCH] D117603: [clang] Don't typo-fix an expression in a SFINAE context

Arthur O'Dwyer via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 3 10:12:35 PST 2022


Quuxplusone added a comment.

In D117603#3292657 <https://reviews.llvm.org/D117603#3292657>, @var-const wrote:

> @Quuxplusone Now that it's landed, do we still need `__workaround_52970` in libc++? (see https://github.com/llvm/llvm-project/blob/167b623a6af26802af47f455aaa3806faaa9da9e/libcxx/include/__concepts/class_or_enum.h#L28-L30)

It's landed in Clang 14, but libc++14 still needs to support Clang 13 for another whole release (six months? a year?), so, no, we can't remove that workaround //yet//.
But you're correct that that's the reason I was kinda hurrying to get it fixed already before the release/14.x branch — it'll mean libc++ gets to remove the workaround 6 (12?) months earlier than otherwise.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117603/new/

https://reviews.llvm.org/D117603



More information about the cfe-commits mailing list