[PATCH] D118922: [ASTMatchers] The `isInline` matcher now accepts inline variables

Evgeny Shulgin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 3 09:27:50 PST 2022


Izaron added inline comments.


================
Comment at: clang/unittests/ASTMatchers/ASTMatchersInternalTest.cpp:195-201
-TEST(IsInlineMatcher, IsInline) {
-  EXPECT_TRUE(matches("void g(); inline void f();",
-                      functionDecl(isInline(), hasName("f"))));
-  EXPECT_TRUE(matches("namespace n { inline namespace m {} }",
-                      namespaceDecl(isInline(), hasName("m"))));
-}
-
----------------
Isn't this test equivalent to the new one I wrote in the other file? The difference between `TEST` and `TEST_P` I see is that the latter one allows you to check C++17 code, while the former does not. So I decided to have all checks in one place.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118922/new/

https://reviews.llvm.org/D118922



More information about the cfe-commits mailing list