[PATCH] D118044: [ARM] Undeprecate complex IT blocks

[Mark Murray via Phabricator via cfe-commits]

MarkMurrayARM marked 3 inline comments as done.
MarkMurrayARM added inline comments.


================
Comment at: llvm/test/CodeGen/ARM/ifcvt-branch-weight.ll:22
+; CHECK: bb.1.bb2:
+; CHECK: successors: %bb.2(0x40000000)
 
----------------
dmgreen wrote:
> I'm not sure this is still checking anything useful. How has the full output changed? Is there not a block with two outputs anymore?
It is a failure caused by my change. 


================
Comment at: llvm/test/CodeGen/Thumb2/v8_IT_3.ll:4
 ; RUN: llc < %s -mtriple=thumbv8 -arm-atomic-cfg-tidy=0 -relocation-model=pic | FileCheck %s --check-prefix=CHECK-PIC
-; RUN: llc < %s -mtriple=thumbv7 -arm-atomic-cfg-tidy=0 -arm-restrict-it -relocation-model=pic | FileCheck %s --check-prefix=CHECK-PIC
+; RUN: llc < %s -mtriple=thumbv7 -arm-atomic-cfg-tidy=0 -arm-restrict-it -relocation-model=pic | FileCheck %s --check-prefix=CHECK-PIC-RESTRICT-IT --check-prefix=CHECK-RESTRICT-IT
 
----------------
dmgreen wrote:
> I'm not sure what this test is doing. Can you just remove -arm-restrict-it and update the check lines?
It's checking restricted ID blocks in position-independent code. I don't see what your request will achieve?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118044/new/

https://reviews.llvm.org/D118044