[PATCH] D118804: Revert "[Clang] Propagate guaranteed alignment for malloc and others"

James Y Knight via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 2 10:00:09 PST 2022


jyknight added a subscriber: collares.
jyknight added a comment.

In D118804#3290874 <https://reviews.llvm.org/D118804#3290874>, @collares wrote:

> might be worth filing a GCC bug as well

Yes, a bug report for GCC should be opened as well. @collares do you want to take that?

In D118804#3290937 <https://reviews.llvm.org/D118804#3290937>, @xbolva00 wrote:

> So better to find solution / agreement with gcc devs too.

Reverting to the previous behavior is safe for clang to do in any case, and thus I think we ought to. Subsequently landing a change that restricts the alignment assumptions based on allocation size would be fine, as well. But reverting the incorrect change doesn't need to wait for that to be written, and neither need wait for a discussion with GCC.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118804/new/

https://reviews.llvm.org/D118804



More information about the cfe-commits mailing list