[PATCH] D118757: [AArch64] Remove unused feature flags from AArch64TargetInfo

Son Tuan Vu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 2 08:51:23 PST 2022


tyb0807 added a comment.

TL;DR, I think these `Has*` flags have different meaning in different places of the code base.

IIUC, these `Has*` flags from `clang/lib/Basic/Targets/AArch64.cpp` are used to correctly set various macros from the processed command line options, notable ones from ACLE, whereas the `Has*` flags from `lib/Driver/ToolChains/Arch/AArch64.cpp` are used to set the target features CL options.

As for the ones in llvm, the original flags are from `AArch64Subtarget` flag, and they are used to describe the architecture features, used in various places in the back-end itself.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118757/new/

https://reviews.llvm.org/D118757



More information about the cfe-commits mailing list