[PATCH] D115856: [syntax][pseudo] Introduce the spec C++ grammar.
    Sam McCall via Phabricator via cfe-commits 
    cfe-commits at lists.llvm.org
       
    Wed Feb  2 08:06:28 PST 2022
    
    
  
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang/lib/Tooling/Syntax/Pseudo/cxx.bnf:40
+# gram.basic
+# !Custom modifications to eliminate optional declaration-seq
+translation-unit := declaration-seq
----------------
nit: `#! Custom` might be more obvious than `# !Custom`
================
Comment at: clang/lib/Tooling/Syntax/Pseudo/cxx.bnf:683
+# gram.lex
+# As we use clang lexer, most of lexical symbols are not needed, we only add
+# needed literals.
----------------
there should be a #! somewhere here
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115856/new/
https://reviews.llvm.org/D115856
    
    
More information about the cfe-commits
mailing list