[PATCH] D118311: [Clang][ModuleMap] Add conditional parsing via requires block declaration

Duncan P. N. Exon Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 1 17:34:01 PST 2022


dexonsmith added a comment.

Drive-by comment on the docs; otherwise this sounds awesome; as long as `else` is easy to add later this SGTM (I'll let others do the code review).

(Although, if `else {}` and `else requires {}` would be easy to add now/soon, I feel like it'd be worth it. Modelling an else-requires chain by hand would be quite error-prone, and it might be annoying to stage the adoption separately...)



================
Comment at: clang/docs/Modules.rst:473
     *module-declaration**
+    *requires-block**
 
----------------
Should this be `*requires-block-declaration*`? I'm not seeing the definition of `*requires-block*` anywhere.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118311/new/

https://reviews.llvm.org/D118311



More information about the cfe-commits mailing list