[PATCH] D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS

[Son Tuan Vu via Phabricator via cfe-commits]

tyb0807 added inline comments.


================
Comment at: clang/lib/Basic/Targets/AArch64.cpp:229
                                                 MacroBuilder &Builder) const {
+  // FIXME: this does not handle the case where MOPS is disabled using +nomops
+  Builder.defineMacro("__ARM_FEATURE_MOPS", "1");
----------------
chill wrote:
> What's the deal with `"+nomops"` ? This FIXME sort of contradicts with an earlier comment
> 
> 
> > Add support for +nomops
> 
> 
I wanted to add support for `+nomops`, but I think it is advisable to keep that in a separate commit to not block this review, so I reverted it with a FIXME


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118199/new/

https://reviews.llvm.org/D118199