[PATCH] D118596: [clang][dataflow] Enable comparison of distinct values in Environment

Stanislav Gatev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 1 07:08:36 PST 2022


sgatev added inline comments.


================
Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:64
+    ///
+    ///  `Val1` must be assigned to a storage location of type `Type`.
+    ///
----------------
ymandel wrote:
> What does this comment mean, now that there's no environment? Could we say something specific to the values themselves?
Updated the comment and added a FIXME to consider removing the type argument.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118596/new/

https://reviews.llvm.org/D118596



More information about the cfe-commits mailing list