[PATCH] D116541: [OpenMP] Introduce new flag to change offloading driver pipeline

[Nico Weber via Phabricator via cfe-commits]

thakis added a comment.

In D116541#3287342 <https://reviews.llvm.org/D116541#3287342>, @jhuber6 wrote:

> In D116541#3287330 <https://reviews.llvm.org/D116541#3287330>, @thakis wrote:
>
>> Tests have been failing on Mac for over 20 hours now. Time to revert and fix async?
>>
>>    % bin/clang -### -fopenmp=libomp -fopenmp-targets=nvptx64-nvidia-cuda -fopenmp-new-driver -no-canonical-prefixes -ccc-print-bindings /Users/thakis/src/llvm-project/clang/test/Driver/openmp-offload-gpu.c -o openmp-offload-gpu -fopenmp -fopenmp-targets=nvptx64 -fopenmp-new-driver -ccc-print-bindings
>>   clang version 14.0.0
>>   Target: x86_64-apple-darwin19.6.0
>>   Thread model: posix
>>   InstalledDir: bin
>>   # "x86_64-apple-darwin19.6.0" - "clang", inputs: ["/Users/thakis/src/llvm-project/clang/test/Driver/openmp-offload-gpu.c"], output: "/var/folders/qt/hxckwtm545l643cnk200wzt00000gn/T/openmp-offload-gpu-729b05.bc"
>>   # "nvptx64-nvidia-cuda" - "clang", inputs: ["/Users/thakis/src/llvm-project/clang/test/Driver/openmp-offload-gpu.c", "/var/folders/qt/hxckwtm545l643cnk200wzt00000gn/T/openmp-offload-gpu-729b05.bc"], output: "/var/folders/qt/hxckwtm545l643cnk200wzt00000gn/T/openmp-offload-gpu-a35969.s"
>>   # "nvptx64-nvidia-cuda" - "NVPTX::Assembler", inputs: ["/var/folders/qt/hxckwtm545l643cnk200wzt00000gn/T/openmp-offload-gpu-a35969.s"], output: "/var/folders/qt/hxckwtm545l643cnk200wzt00000gn/T/openmp-offload-gpu-a3f7f0.o"
>>   # "x86_64-apple-darwin19.6.0" - "clang", inputs: ["/Users/thakis/src/llvm-project/clang/test/Driver/openmp-offload-gpu.c", "/var/folders/qt/hxckwtm545l643cnk200wzt00000gn/T/openmp-offload-gpu-a3f7f0.o"], output: "/var/folders/qt/hxckwtm545l643cnk200wzt00000gn/T/openmp-offload-gpu-f53552.bc"
>>   # "x86_64-apple-darwin19.6.0" - "clang", inputs: ["/var/folders/qt/hxckwtm545l643cnk200wzt00000gn/T/openmp-offload-gpu-f53552.bc"], output: "/var/folders/qt/hxckwtm545l643cnk200wzt00000gn/T/openmp-offload-gpu-86f846.o"
>>   # "x86_64-apple-darwin19.6.0" - "Offload::Linker", inputs: ["/var/folders/qt/hxckwtm545l643cnk200wzt00000gn/T/openmp-offload-gpu-86f846.o"], output: "openmp-offload-gpu"
>
> I'd rather just disable the test, this patch has like 20 others that depend on it so we'd need to revert all of those. It's definitely not grabbing the bitcode from the cache as expected. I can disable this part of the test for now, but do you know how I could figure out how to reproduce this? I've been tracking some other buildbots and they don't seem to have the same issue so I'm not sure what's special about this one.

Just build and run tests on any mac. This fails on 3 different macs I tried (2x arm, 1x intel), in a bunch of different build configs.

For the particular build I sent the output from, the cmake invocation looked like `/Applications/CMake.app/Contents/bin/cmake -GNinja -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=ON -DLLVM_ENABLE_PROJECTS='compiler-rt;libcxx;clang' -DLLVM_APPEND_VC_REV=NO -DCMAKE_C_COMPILER=$HOME/src/chrome/src/third_party/llvm-build/Release+Asserts/bin/clang -DCMAKE_CXX_COMPILER=$HOME/src/chrome/src/third_party/llvm-build/Release+Asserts/bin/clang++ -DCMAKE_OSX_SYSROOT=/Users/thakis/src/llvm-project/sysroot/MacOSX.sdk -DDARWIN_macosx_CACHED_SYSROOT=/Users/thakis/src/llvm-project/sysroot/MacOSX.sdk -DDARWIN_iphoneos_CACHED_SYSROOT=/Users/thakis/src/llvm-project/sysroot/iPhoneOS.sdk -DDARWIN_iphonesimulator_CACHED_SYSROOT=/Users/thakis/src/llvm-project/sysroot/iPhoneSimulator.sdk ../llvm`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116541/new/

https://reviews.llvm.org/D116541