[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

[Timm Bäder via Phabricator via cfe-commits]

tbaeder marked an inline comment as done.
tbaeder added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:445
     addSystemInclude(DriverArgs, CC1Args,
-                     getDriver().SysRoot + "/include/c++/v1");
+                     getDriver().SysRoot + "/include/c++/11");
+    break;
----------------
sbc100 wrote:
> Can't these 6 lines be removed now?  (don't they happen as part of addLibStdCXXIncludePaths?)
Yep, just a leftover, sorry.


================
Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:544
+
+  if (Version.empty()) {
+    // FIXME: Fallback correct?
----------------
sbc100 wrote:
> Just early return here if no headers can be found?  Looking at Gnu.cpp it seems that `addLibStdCxxIncludePaths` can simply to nothing if no GCC install is found.
I saw that, but I'm not sure if this is correct for wasm. The tests certainly break because they check for the `/v1/` (and not `/11/`) include paths but also use `-sysroot=/foo`, so the new code doesn't add any flags. Is there a good way to update the tests so they stay functional and useful?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117888/new/

https://reviews.llvm.org/D117888